-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hf_transfer to testing image #10096
Add hf_transfer to testing image #10096
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe you also need to turn it on via env var? just set HF_HUB_ENABLE_HF_TRANSFER=1
globally
I thought the automatic enablement of the env var would be taken care of by this: vllm/vllm/model_executor/model_loader/weight_utils.py Lines 39 to 51 in a62bc01
But the fastcheck times are the same - I will try manually enabling. |
This pull request has merge conflicts that must be resolved before it can be |
The models tests are significantly faster on average, so I think this is working now. |
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Loc Huynh <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
Signed-off-by: Maxime Fournioux <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
Installs the hf_transfer package into the test image in the dockerfile so all the CUDA buildkite tests can have faster model downloads