-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable spec-decode + chunked-prefill for draft models with tensor parallelism > 1 #10136
Conversation
Pull from head
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Sourashis Roy <[email protected]>
@njhill / @LiuXiaoxuanPKU this pr is ready for review. Could you ptal when you get a chance? cc: @NickLucche |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Head branch was pushed to by a user without write access
…rallelism > 1 (vllm-project#10136) Signed-off-by: Sourashis Roy <[email protected]> Signed-off-by: Isotr0py <[email protected]>
…rallelism > 1 (vllm-project#10136) Signed-off-by: Sourashis Roy <[email protected]> Signed-off-by: Loc Huynh <[email protected]>
…rallelism > 1 (vllm-project#10136) Signed-off-by: Sourashis Roy <[email protected]> Signed-off-by: Jee Jee Li <[email protected]>
…rallelism > 1 (vllm-project#10136) Signed-off-by: Sourashis Roy <[email protected]>
…rallelism > 1 (vllm-project#10136) Signed-off-by: Sourashis Roy <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
…rallelism > 1 (vllm-project#10136) Signed-off-by: Sourashis Roy <[email protected]>
…rallelism > 1 (vllm-project#10136) Signed-off-by: Sourashis Roy <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
…rallelism > 1 (vllm-project#10136) Signed-off-by: Sourashis Roy <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
…rallelism > 1 (vllm-project#10136) Signed-off-by: Sourashis Roy <[email protected]>
In this pr we are disabling the simulataneous enablement of both spec-decode & chunked-prefill if the draft model has a tp of > 1. This is needed because as reported in #9291 we see errors if both are enabled for draft model with tp> 1. After this change for this command we return the following error