Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reporting metrics in completion response headers in o… #10484

Closed
wants to merge 1 commit into from

Conversation

coolkp
Copy link
Contributor

@coolkp coolkp commented Nov 20, 2024

FIX #10086

Implement

  • reporting of metrics in completion response headers in orca format
  • reporting of metrics in orca proto format in Orca metrics proto #10475

image
image

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the frontend label Nov 20, 2024
@coolkp coolkp force-pushed the metric-orca-headers branch 8 times, most recently from 3c558dd to d6ab92e Compare November 20, 2024 18:04
@coolkp coolkp force-pushed the metric-orca-headers branch from d6ab92e to 430d948 Compare November 21, 2024 02:13
Copy link

mergify bot commented Dec 17, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @coolkp.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 17, 2024
@coolkp
Copy link
Contributor Author

coolkp commented Feb 6, 2025

dropping in favor of #12854. only in header no overhead for default case

@coolkp coolkp closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Enhance integration with advanced LB/gateways with better load/cost reporting and LoRA management
1 participant