[Core] remove temporary local variables in LLMEngine.__init__ #10577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These local variables were no longer necessary. They just helped reduce the size of a previous change. Drop them and replace usage with the equivalent instance variables. This also removed some unnecessary duplicate assignments that were doing `B = A` after assigning `A = B` just above it prior to a big log message. Signed-off-by: Russell Bryant <[email protected]>
russellb
requested review from
zhuohan123,
youkaichao,
alexm-neuralmagic,
comaniac and
njhill
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
youkaichao
approved these changes
Nov 22, 2024
github-actions
bot
added
the
ready
mgoin
approved these changes
Nov 22, 2024
tlrmchlsmth
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 23, 2024
…roject#10577) Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
mfournioux
pushed a commit
to mfournioux/vllm
that referenced
this pull request
Nov 28, 2024
…roject#10577) Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
sleepwalker2017
pushed a commit
to sleepwalker2017/vllm
that referenced
this pull request
Dec 13, 2024
…roject#10577) Signed-off-by: Russell Bryant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These local variables were no longer necessary. They just helped
reduce the size of a previous change. Drop them and replace usage with
the equivalent instance variables.
This also removed some unnecessary duplicate assignments that were
doing
B = Aafter assigningA = Bjust above it prior to a big logmessage.
Signed-off-by: Russell Bryant [email protected]