Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] typo find in sampling_metadata.py #10740

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

noooop
Copy link
Contributor

@noooop noooop commented Nov 28, 2024

#5639

Forgot to copy

sampling_params = seq_group.sampling_params

Sampling part is too complicated, can anyone refactor it?

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 29, 2024 03:58
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 29, 2024
@DarkLight1337 DarkLight1337 merged commit c82b432 into vllm-project:main Nov 29, 2024
55 of 58 checks passed
@youkaichao
Copy link
Member

I think lots of sequence group related code can be deleted now, after #9302 . but I don't have bandwidth recently.

@noooop
Copy link
Contributor Author

noooop commented Nov 29, 2024

I think lots of sequence group related code can be deleted now, after #9302 . but I don't have bandwidth recently.

I am carefully deleting the sequence group step by step in my project. It is really a headache.

@youkaichao
Copy link
Member

@noooop can you join vllm slack? we can discuss it to plan how to remove it. the url for vllm slack is https://slack.vllm.ai .

afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants