-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] typo find in sampling_metadata.py #10740
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, thanks for fixing!
I think lots of sequence group related code can be deleted now, after #9302 . but I don't have bandwidth recently. |
I am carefully deleting the sequence group step by step in my project. It is really a headache. |
@noooop can you join vllm slack? we can discuss it to plan how to remove it. the url for vllm slack is https://slack.vllm.ai . |
Signed-off-by: Andrew Feldman <[email protected]>
#5639
Forgot to copy
Sampling part is too complicated, can anyone refactor it?