Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] Move async output check to platform #10768

Conversation

wangxiyuan
Copy link
Contributor

@wangxiyuan wangxiyuan commented Nov 29, 2024

Part of #9268

This is the last PR for platform reactor for config module.

This PR move the async output ability check to platform to avoid device hard code in config module.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@wangxiyuan wangxiyuan force-pushed the Cleanup_device_code_in_vllm_config branch 5 times, most recently from a829e6f to 40dc691 Compare November 29, 2024 09:28
Copy link

mergify bot commented Nov 29, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @wangxiyuan.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 29, 2024
@wangxiyuan wangxiyuan force-pushed the Cleanup_device_code_in_vllm_config branch from 40dc691 to f84256a Compare November 30, 2024 00:35
@mergify mergify bot removed the needs-rebase label Nov 30, 2024
Copy link

mergify bot commented Dec 3, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @wangxiyuan.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 3, 2024
@wangxiyuan wangxiyuan force-pushed the Cleanup_device_code_in_vllm_config branch from f84256a to aedb027 Compare December 9, 2024 07:27
@mergify mergify bot removed the needs-rebase label Dec 9, 2024
@DarkLight1337
Copy link
Member

Looks good now, thanks!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 9, 2024 13:49
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 9, 2024
@DarkLight1337 DarkLight1337 merged commit aea2fc3 into vllm-project:main Dec 9, 2024
58 of 61 checks passed
@wangxiyuan wangxiyuan deleted the Cleanup_device_code_in_vllm_config branch December 11, 2024 08:49
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@wangxiyuan wangxiyuan mentioned this pull request Dec 19, 2024
1 task
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants