Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model] Refactor Molmo weights loading to use AutoWeightsLoader #10771

Merged
merged 5 commits into from
Nov 30, 2024
Merged

[Model] Refactor Molmo weights loading to use AutoWeightsLoader #10771

merged 5 commits into from
Nov 30, 2024

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Nov 29, 2024 •
edited by github-actions bot
Loading

  • Refactor Molmo weights loading to use WeightsMapper and AutoWeightsLoader

@Isotr0py
refactor molmo weights loading
4d72286 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
fix typos
c63153b 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
fix a typo
fce9a04 
Signed-off-by: Isotr0py <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Isotr0py
apply mapper twice
1faf65c 
Signed-off-by: Isotr0py <[email protected]>
DarkLight1337
DarkLight1337 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, you can merge once you have tested the model.

@Isotr0py Isotr0py enabled auto-merge (squash) November 29, 2024 14:41
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 29, 2024
@Isotr0py Isotr0py merged commit 16ee07f into vllm-project:main Nov 30, 2024
59 checks passed
@Isotr0py Isotr0py deleted the refactor-molmo branch November 30, 2024 04:39
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
@Isotr0py @afeldman-nm
[Model] Refactor Molmo weights loading to use AutoWeightsLoader (vllm…
d95da87 
…-project#10771)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
cedonley pushed a commit to cedonley/vllm that referenced this pull request Dec 7, 2024
@Isotr0py @cedonley
[Model] Refactor Molmo weights loading to use AutoWeightsLoader (vllm…
f5c1aae 
…-project#10771)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: cedonley <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@Isotr0py
[Model] Refactor Molmo weights loading to use AutoWeightsLoader (vllm…
050f4ff 
…-project#10771)

Signed-off-by: Isotr0py <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isotr0py @DarkLight1337