Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Turn on basic correctness tests for V1 #10864

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

tlrmchlsmth
Copy link
Collaborator

Ran into some OOM issues in #9856. Turning on this test to see if the problems happen without the TP changes.

Copy link

github-actions bot commented Dec 3, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@tlrmchlsmth tlrmchlsmth changed the title [CI] Turn on basic correctnes tests for V1 [CI] Turn on basic correctness tests for V1 Dec 3, 2024
Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
@WoosukKwon
Copy link
Collaborator

@tlrmchlsmth do we still have any issues on merging this PR?

@tlrmchlsmth
Copy link
Collaborator Author

@WoosukKwon I tried it again after merging #9856 but it's still red. Maybe there are issues with the UniprocExecutor that can be resolved one way or another ✂️

@wubai
Copy link

wubai commented Dec 21, 2024

logits = self.model.compute_logits(hidden_states, None)

@tlrmchlsmth logits = self.model.compute_logits(hidden_states, None) comsume much more memory than V0, that lead to the OOM. But I don't know how to figure it out.

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 8, 2025
@tlrmchlsmth
Copy link
Collaborator Author

@tlrmchlsmth logits = self.model.compute_logits(hidden_states, None) comsume much more memory than V0, that lead to the OOM. But I don't know how to figure it out.

Hey, I'm pretty sure the failure was due to the engine cleaning up improperly previously, but curious what you were seeing before?

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this enabled

@mgoin mgoin merged commit 615e4a5 into vllm-project:main Jan 9, 2025
47 checks passed
frreiss pushed a commit to frreiss/vllm that referenced this pull request Jan 10, 2025
frreiss pushed a commit to frreiss/vllm that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants