Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add contributor docs on installing vllm_test_utils #10872

Closed
wants to merge 1 commit into from
Closed

[Doc] Add contributor docs on installing vllm_test_utils #10872

wants to merge 1 commit into from

Conversation

markmc
Copy link
Contributor

@markmc markmc commented Dec 3, 2024 •
edited by github-actions bot
Loading

Since #10659 (commit 334d64d), you need to install the vllm_test_utils package before running the unit tests.

@markmc
[Doc] Add contributor docs on installing vllm_test_utils
8463cc2 
Since vllm-project#10659 (commit 334d64d), you need to install the
`vllm_test_utils` package before running the unit tests.

Signed-off-by: Mark McLoughlin <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 3, 2024
@markmc
Copy link
Contributor Author

markmc commented Dec 3, 2024

Hmm, I now understand that pytest tests/ isn't realistically part of a new contributor's workflow

@markmc markmc closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@markmc