Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc][LoRA] Refactor and clean MergedQKVParallelLinearWithLora implementation #10958

Merged
merged 6 commits into from
Dec 7, 2024

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Dec 6, 2024

This PR aims to clean up MergedColumnParallelLinearWithLora and MergedQKVParallelLinearWithLora implementation

  • MergedQKVParallelLinearWithLora has a similar weights initialization with MergedColumnParallelLinearWithLora, and we can treat it as a special case of MergedColumnParallelLinearWithLora with arbitrary shard_size.
  • Therefore, we can further clean up MergedQKVParallelLinearWithLora implementation based on MergedColumnParallelLinearWithLora.

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Copy link

github-actions bot commented Dec 6, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Isotr0py Isotr0py requested a review from jeejeelee December 6, 2024 17:20
Signed-off-by: Isotr0py <[email protected]>
vllm/lora/layers.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks four your clean up, LGTM

Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 7, 2024
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py merged commit b26b4cd into vllm-project:main Dec 7, 2024
53 checks passed
@Isotr0py Isotr0py deleted the refactor-merged-lora branch December 7, 2024 10:33
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants