-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc][LoRA] Refactor and clean MergedQKVParallelLinearWithLora implementation #10958
Conversation
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Isotr0py <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks four your clean up, LGTM
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
…mentation (vllm-project#10958) Signed-off-by: Isotr0py <[email protected]>
…mentation (vllm-project#10958) Signed-off-by: Isotr0py <[email protected]>
This PR aims to clean up
MergedColumnParallelLinearWithLora
andMergedQKVParallelLinearWithLora
implementationMergedQKVParallelLinearWithLora
has a similar weights initialization withMergedColumnParallelLinearWithLora
, and we can treat it as a special case ofMergedColumnParallelLinearWithLora
with arbitrary shard_size.MergedQKVParallelLinearWithLora
implementation based onMergedColumnParallelLinearWithLora
.