Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] Check transformers v4.47 #10991

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Dec 8, 2024

See if it's safe to update to transformers v4.47 by running our CI on the new version.

Copy link

github-actions bot commented Dec 8, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 changed the title [Ci/Build] Test transformers v4.47 [CI/Build] Test transformers v4.47 Dec 8, 2024
@mergify mergify bot added the ci/build label Dec 8, 2024
@DarkLight1337 DarkLight1337 changed the title [CI/Build] Test transformers v4.47 [CI/Build] Check transformers v4.47 Dec 8, 2024
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 10, 2024
@Isotr0py
Copy link
Collaborator

Isotr0py commented Dec 10, 2024

Seems that test_video.py for entrypoint test is failing in CI, let me run it locally to have a look...

@DarkLight1337
Copy link
Member Author

I think it's just a timeout error from downloading the video.

@Isotr0py
Copy link
Collaborator

Oh, yea, just realized it's due to timeout. The entrypoint test CI log is too long to read. 😅

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 10, 2024 15:03
Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since the failing entrypoint test passed on my side.

BTW, we need to address the failling mamba test in a following PR as well.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 10, 2024 15:06
@DarkLight1337 DarkLight1337 merged commit 2e33fe4 into vllm-project:main Dec 11, 2024
86 of 90 checks passed
@DarkLight1337 DarkLight1337 deleted the test-transformers-447 branch December 11, 2024 05:06
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Dec 12, 2024
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Akshat Tripathi <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants