Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc][LoRA] Add PEFTHelper for LoRA #11003

Merged
merged 8 commits into from
Dec 10, 2024

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Dec 9, 2024

Motivation

This PR introduces a new PEFTHelper class to LoRA feature management , include:

  • Built-in validation for unsupported feature (RSLoRA, DoRA and so on) , and enhances error handling by explicitly throwing exceptions for unsupported features.
  • Make it easier to integrate future PEFT features
  • consolidate long LoRA configuration

TODO

  • Improve the logic
  • Add unit test

@jeejeelee jeejeelee marked this pull request as draft December 9, 2024 03:43
Copy link

github-actions bot commented Dec 9, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee jeejeelee marked this pull request as ready for review December 10, 2024 03:43
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 10, 2024 04:15
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 10, 2024
Signed-off-by: Jee Jee Li <[email protected]>
@DarkLight1337 DarkLight1337 merged commit d05f886 into vllm-project:main Dec 10, 2024
53 checks passed
@jeejeelee jeejeelee deleted the enhance-lora-config branch December 10, 2024 14:01
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants