Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove token param #10921 #11022

Merged
merged 3 commits into from
Dec 10, 2024
Merged

[BUG] Remove token param #10921 #11022

merged 3 commits into from
Dec 10, 2024

Conversation

flaviabeo
Copy link
Contributor

@flaviabeo flaviabeo commented Dec 9, 2024 •
edited by github-actions bot
Loading

  • Set the HF_TOKEN environment variable as recommended

FIX #10921

@flaviabeo
[BUG] Remove token param vllm-project#10921
5fa812a 
- Set the HF_TOKEN environment variable as recommended

Signed-off-by: Flavia Beo <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@flaviabeo
Fix param type
ffcad6f 
Signed-off-by: Flavia Beo <[email protected]>
DarkLight1337
DarkLight1337 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337
Copy link
Member

Please merge from main to fix the CI failure.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 10, 2024 10:58
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 10, 2024
@DarkLight1337 DarkLight1337 merged commit 250ee65 into vllm-project:main Dec 10, 2024
51 of 54 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Dec 12, 2024
@flaviabeo @Akshat-Tripathi
[BUG] Remove token param vllm-project#10921 (vllm-project#11022)
44136ff 
Signed-off-by: Flavia Beo <[email protected]>
Signed-off-by: Akshat Tripathi <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@flaviabeo
[BUG] Remove token param vllm-project#10921 (vllm-project#11022)
ca25ede 
Signed-off-by: Flavia Beo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]:
2 participants
@flaviabeo @DarkLight1337