Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Use input_ids as input for text-only models #11032

Merged
merged 9 commits into from
Dec 11, 2024
Merged

Conversation

WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Dec 9, 2024

Currently, the model runner in V1 always uses input_embeds rather than input_ids for the compatibility with multi-modal models. However, this excludes the embedding layer from the CUDA graph, and thus causes slight performance regression (and larger performance regression when TP > 1). This PR addresses this by using the input_ids for text-only models while keeping using input_embeds for multi-modal models.

Copy link

github-actions bot commented Dec 9, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
@ywang96 ywang96 self-assigned this Dec 10, 2024
@WoosukKwon
Copy link
Collaborator Author

Chatted offline with @ywang96, while we also need to support input embeddings for text-only models, this PR is good to go since the API is still not ready for V1.

@WoosukKwon WoosukKwon merged commit d643c2a into main Dec 11, 2024
22 of 25 checks passed
@WoosukKwon WoosukKwon deleted the v1-embedding-cg branch December 11, 2024 18:49
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Dec 12, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants