Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pixtral] Improve loading #11040

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Dec 9, 2024

Pixtral loading was very memory-inefficient before because itertool's tee operator required 3x more memory than necessary. This PR fixes it

@patrickvonplaten patrickvonplaten changed the title WIP [Pixtral] Improve loading Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@patrickvonplaten
Copy link
Contributor Author

cc @ywang96

@ywang96 ywang96 self-assigned this Dec 9, 2024
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 9, 2024
@ywang96 ywang96 enabled auto-merge (squash) December 9, 2024 23:34
@ywang96 ywang96 merged commit bc192a2 into vllm-project:main Dec 10, 2024
65 checks passed
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants