Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix streaming for granite tool call when <|tool_call|> is present #11069

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Fix streaming for granite tool call when <|tool_call|> is present #11069

merged 1 commit into from
Dec 11, 2024
+5 −1

Conversation

maxdebayser
Copy link
Contributor

@maxdebayser maxdebayser commented Dec 10, 2024 •
edited by github-actions bot
Loading

This is a follow up for the streaming case for this PR: #11039

cc: @tjohnson31415 , @DarkLight1337

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the frontend label Dec 10, 2024
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 11, 2024 03:13
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 11, 2024
@DarkLight1337 DarkLight1337 merged commit e39400a into vllm-project:main Dec 11, 2024
65 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Dec 12, 2024
@maxdebayser @Akshat-Tripathi
Fix streaming for granite tool call when <|tool_call|> is present (vl…
a8d9563 
…lm-project#11069)

Signed-off-by: Max de Bayser <[email protected]>
Signed-off-by: Akshat Tripathi <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@maxdebayser
Fix streaming for granite tool call when <|tool_call|> is present (vl…
86ef9e6 
…lm-project#11069)

Signed-off-by: Max de Bayser <[email protected]>
@K-Mistele K-Mistele mentioned this pull request Dec 22, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxdebayser @DarkLight1337