[Core] Update outlines and increase its threadpool size #11140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
russellb
changed the title
mgoin
reviewed
Dec 12, 2024
russellb
force-pushed
the
outlines-0.10.0
branch
from
50f08e3 to
a07b908
Compare
This was referenced Dec 13, 2024
auto-merge was automatically disabled
December 13, 2024 22:35
Head branch was pushed to by a user without write access
russellb
force-pushed
the
outlines-0.10.0
branch
from
fc1ce15 to
17c0d32
Compare
outlines 0.10.0 was just released and includes some performance improvements. I tested it successfully in my env and saw some improvement, so I think we should bump the version. Signed-off-by: Russell Bryant <[email protected]>
outlines 0.1.10 includes some improvements to parallelization. I noticed that this threadpool was hard-coded to a size of 2. This uses the host's CPU count instead. The improvement is not huge, but is measurable. Signed-off-by: Russell Bryant <[email protected]>
As of this version, arm wheels should be available! dottxt-ai/outlines-core#122 Signed-off-by: Russell Bryant <[email protected]>
russellb
force-pushed
the
outlines-0.10.0
branch
from
17c0d32 to
f364718
Compare
ZenPuzzle
pushed a commit
to ZenPuzzle/vllm
that referenced
this pull request
Dec 24, 2024
…#11140) Signed-off-by: Russell Bryant <[email protected]>
BKitor
pushed a commit
to BKitor/vllm
that referenced
this pull request
Dec 30, 2024
…#11140) Signed-off-by: Russell Bryant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6c2b68e [Build/CI] Update outlines to 0.10.0
a07b908 outlines: Scale thread pool size based on cpu count
fc1ce15 Update to outlines-0.1.11
commit 6c2b68e
Author: Russell Bryant [email protected]
Date: Thu Dec 12 14:33:15 2024 +0000
commit a07b908
Author: Russell Bryant [email protected]
Date: Thu Dec 12 15:09:20 2024 +0000
commit fc1ce15
Author: Russell Bryant [email protected]
Date: Fri Dec 13 15:05:07 2024 +0000
Closes #11178
Before (closer to 0.1.8):
After (with 0.1.10):
with 0.1.10 + threadpool size increase: