Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): typo in helm install instructions #11141

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix(docs): typo in helm install instructions #11141

merged 1 commit into from
Dec 12, 2024

Conversation

ramonziai
Copy link
Contributor

@ramonziai ramonziai commented Dec 12, 2024 •
edited by github-actions bot
Loading

Fix typo s3buckername.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 12, 2024
@ramonziai
fix(docs): typo in helm install instructions
b6eaa0c 
Fix typo `s3buckername`.

Signed-off-by: Ramon Ziai <[email protected]>
DarkLight1337
DarkLight1337 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 12, 2024 16:01
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 12, 2024
@DarkLight1337 DarkLight1337 merged commit d4d5291 into vllm-project:main Dec 12, 2024
46 checks passed
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@ramonziai
fix(docs): typo in helm install instructions (vllm-project#11141)
f279193 
Signed-off-by: Ramon Ziai <[email protected]>
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@ramonziai @BKitor
fix(docs): typo in helm install instructions (vllm-project#11141)
02966b3 
Signed-off-by: Ramon Ziai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes

@russellb russellb russellb approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ramonziai @russellb @tlrmchlsmth @DarkLight1337