Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Use runner_type instead of task in GritLM #11144

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

pooyadavoodi
Copy link
Contributor

While the GritLM PR #10816 was merged, #10820 added new type of pooling tasks to vllm. Since GritLM pooling logic relied on the task type, the tests started to fail. This PR is now using runner_type instead of task in the pooling logic.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 13, 2024 02:48
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 13, 2024
@DarkLight1337 DarkLight1337 merged commit 1efce68 into vllm-project:main Dec 13, 2024
68 checks passed
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants