Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Convert rST to MyST (Markdown) #11145

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

rafvasq
Copy link
Contributor

@rafvasq rafvasq commented Dec 12, 2024

This PR migrates the existing documentation from reStructuredText to MyST Markdown, a flavour of Markdown extended for use with Sphinx.

  • Add .md template to gitignore
  • Upgrade myst-parser to 3.0.1
  • Converts .rst docs into .md, preserving content and formatting
  • Update filename references to docs from .rst to .md
  • In front-end code, update class/function definition references to documentation
    • e.g. :ref: engine_args -> [engine-args](#engine-args)

Closes #10427

Signed-off-by: Rafael Vasquez <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 12, 2024
Copy link

mergify bot commented Dec 12, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @rafvasq.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 12, 2024
@DarkLight1337 DarkLight1337 self-assigned this Dec 13, 2024
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
@mergify mergify bot added the ci/build label Dec 16, 2024
Signed-off-by: Rafael Vasquez <[email protected]>
@mergify mergify bot added the frontend label Dec 17, 2024
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
@mergify mergify bot removed the needs-rebase label Dec 18, 2024
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq rafvasq marked this pull request as ready for review December 18, 2024 20:32
- :ref:`input_processing_pipeline`
- :ref:`enabling_multimodal_inputs`
- [input-processing-pipeline](#input-processing-pipeline)
- [enabling-multimodal-inputs](#enabling-multimodal-inputs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into it, and it turns out that sphinx.ext.autodoc is not compatible with MyST Markdown, but still usable: the simple workaround is that docstrings still use rST. It's working now: https://vllm--11145.org.readthedocs.build/en/11145/design/multimodal/multimodal_index.html#registry.

Longer term, because I think it warrants its own PR, the solution is to use autodoc2 by Sphinx, which supports MyST.

Copy link

mergify bot commented Dec 19, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @rafvasq.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 19, 2024
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
@mergify mergify bot removed the needs-rebase label Dec 19, 2024
Signed-off-by: Rafael Vasquez <[email protected]>
@DarkLight1337
Copy link
Member

DarkLight1337 commented Dec 20, 2024

I'll take a look at the files one by one this weekend.

Let's try to get this in sometime during the Christmas holidays so we don't get as many merge conflicts 😅

Signed-off-by: Rafael Vasquez <[email protected]>
Copy link

mergify bot commented Dec 20, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @rafvasq.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 20, 2024
Signed-off-by: Rafael Vasquez <[email protected]>
@mergify mergify bot removed the needs-rebase label Dec 20, 2024
Signed-off-by: Rafael Vasquez <[email protected]>
@youkaichao
Copy link
Member

is it possible to keep both rst and myst, so that we can update the doc files one by one in many PRs?

this large PR will easily have conflicts :(

@simon-mo
Copy link
Collaborator

i think we should just quickly merge at once, as soon as all the previews are checked for accuracy.

Signed-off-by: Rafael Vasquez <[email protected]>

### Python-only build (without compilation)

If you only need to change Python code, you can build and install vLLM without compilation. Using `` pip's ` ``--editable\`\` flag \<<https://pip.pypa.io/en/stable/topics/local-project-installs/#editable-installs>>\`\_, changes you make to the code will be reflected when you run vLLM:
Copy link
Member

@DarkLight1337 DarkLight1337 Dec 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link here appears to be broken (that being said, this is also the case on main branch).

@DarkLight1337
Copy link
Member

The links for code examples (e.g. https://vllm--11145.org.readthedocs.build/en/11145/getting_started/examples/api_client.html) are also broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: Migrate to Markdown
4 participants