-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Convert rST to MyST (Markdown) #11145
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Rafael Vasquez <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
vllm/multimodal/registry.py
Outdated
- :ref:`input_processing_pipeline` | ||
- :ref:`enabling_multimodal_inputs` | ||
- [input-processing-pipeline](#input-processing-pipeline) | ||
- [enabling-multimodal-inputs](#enabling-multimodal-inputs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like markdown format works here:
https://vllm--11145.org.readthedocs.build/en/11145/design/multimodal/multimodal_index.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into it, and it turns out that sphinx.ext.autodoc
is not compatible with MyST Markdown, but still usable: the simple workaround is that docstrings still use rST. It's working now: https://vllm--11145.org.readthedocs.build/en/11145/design/multimodal/multimodal_index.html#registry.
Longer term, because I think it warrants its own PR, the solution is to use autodoc2
by Sphinx, which supports MyST.
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
I'll take a look at the files one by one this weekend. Let's try to get this in sometime during the Christmas holidays so we don't get as many merge conflicts 😅 |
Signed-off-by: Rafael Vasquez <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
is it possible to keep both rst and myst, so that we can update the doc files one by one in many PRs? this large PR will easily have conflicts :( |
i think we should just quickly merge at once, as soon as all the previews are checked for accuracy. |
Signed-off-by: Rafael Vasquez <[email protected]>
|
||
### Python-only build (without compilation) | ||
|
||
If you only need to change Python code, you can build and install vLLM without compilation. Using `` pip's ` ``--editable\`\` flag \<<https://pip.pypa.io/en/stable/topics/local-project-installs/#editable-installs>>\`\_, changes you make to the code will be reflected when you run vLLM: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link here appears to be broken (that being said, this is also the case on main branch).
The links for code examples (e.g. https://vllm--11145.org.readthedocs.build/en/11145/getting_started/examples/api_client.html) are also broken. |
This PR migrates the existing documentation from reStructuredText to MyST Markdown, a flavour of Markdown extended for use with Sphinx.
.md
template to gitignoremyst-parser
to3.0.1
.rst
docs into.md
, preserving content and formatting.rst
to.md
:ref: engine_args
->[engine-args](#engine-args)
Closes #10427