Skip to content

Conversation

comaniac
Copy link
Collaborator

@comaniac comaniac commented Dec 12, 2024

Fix the type error reported by #11105

cc @WoosukKwon @markmc

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@comaniac comaniac enabled auto-merge (squash) December 12, 2024 23:15
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 12, 2024
Signed-off-by: Cody Yu <[email protected]>
@comaniac comaniac merged commit 78ed8f5 into vllm-project:main Dec 13, 2024
50 checks passed
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@comaniac comaniac deleted the v1-fix-type branch January 3, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants