-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Platform] platform agnostic for EngineArgs initialization #11225
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
ee14d97
to
5073878
Compare
5073878
to
b3100a9
Compare
Signed-off-by: wangxiyuan <[email protected]>
b3100a9
to
1773a02
Compare
I think there should be a friendly way to quickly look up the default values of parameters. It's a bit unintuitive to initialize all platform-related parameters to None right now. |
when you run vllm, there should be one line of logging showing all the values (which are default values). It's a bit unintuitive, but we have no choice since we need to support multiple platforms. |
…ect#11225) Signed-off-by: wangxiyuan <[email protected]>
EngineArgs
initialization runs before plugin loading, so it should be platform agnostic.Once platform plugin is supported, calling platform related code during
EngineArgs
initialization will lead error.This PR clean up the platform specified code during
EngineArgs
initialization step.