Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] platform agnostic for EngineArgs initialization #11225

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

wangxiyuan
Copy link
Contributor

@wangxiyuan wangxiyuan commented Dec 16, 2024

EngineArgs initialization runs before plugin loading, so it should be platform agnostic.

Once platform plugin is supported, calling platform related code during EngineArgs initialization will lead error.

This PR clean up the platform specified code during EngineArgs initialization step.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@wangxiyuan wangxiyuan changed the title [Platform] platform agnostic for EngineArgs Init [Platform] platform agnostic for EngineArgs initialization Dec 16, 2024
@wangxiyuan wangxiyuan force-pushed the fix_engine_args branch 3 times, most recently from ee14d97 to 5073878 Compare December 16, 2024 08:18
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 17, 2024 03:31
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 17, 2024
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 17, 2024 03:43
@youkaichao youkaichao disabled auto-merge December 17, 2024 06:10
@youkaichao youkaichao merged commit e88db68 into vllm-project:main Dec 17, 2024
63 of 68 checks passed
@wangxiyuan wangxiyuan mentioned this pull request Dec 19, 2024
1 task
@wangxiyuan wangxiyuan deleted the fix_engine_args branch December 30, 2024 08:20
@yansh97
Copy link
Contributor

yansh97 commented Dec 30, 2024

I think there should be a friendly way to quickly look up the default values of parameters. It's a bit unintuitive to initialize all platform-related parameters to None right now.

@youkaichao
Copy link
Member

youkaichao commented Dec 30, 2024

I think there should be a friendly way to quickly look up the default values of parameters

when you run vllm, there should be one line of logging showing all the values (which are default values). It's a bit unintuitive, but we have no choice since we need to support multiple platforms.

BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants