[Bugfix][CI] ALiBi test case in xformers multi_query_kv_attention #11301
+50
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been meaning to add a test case to address this TODO https://github.com/vllm-project/vllm/blob/main/tests/kernels/test_attention.py#L367 but I then realized the test would break due to a dim expansion of the attention bias happening here https://github.com/vllm-project/vllm/blob/main/vllm/attention/backends/xformers.py#L783.
Therefore, this PR adds a test case for xformers multi query+alibi bias and fixes the previously untested scenario.