Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Fix multimodal profiling #11308

Closed
wants to merge 1 commit into from

Conversation

ywang96
Copy link
Member

@ywang96 ywang96 commented Dec 18, 2024

#11187 introduced a change that breaks #11210. The issue was previously missed because the two PRs were merged into main around the same time.

fix
Signed-off-by: ywang96 <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 18, 2024
Copy link
Collaborator

@alexm-neuralmagic alexm-neuralmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@comaniac comaniac enabled auto-merge (squash) December 18, 2024 22:40
Copy link

mergify bot commented Dec 19, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @ywang96.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 19, 2024
@DarkLight1337
Copy link
Member

Closing as superseded by #11305

auto-merge was automatically disabled December 19, 2024 03:47

Pull request was closed

@ywang96
Copy link
Member Author

ywang96 commented Dec 19, 2024

Closing as superseded by #11305

Oh neat! I didn't see that PR actually fixed this already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants