Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] add early error message for custom ops #11355

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

youkaichao
Copy link
Member

@youkaichao youkaichao commented Dec 20, 2024

reported by @joschu-anthropic

I think it might also solve #2021 (comment) , cc @yajuvendrarawat

Signed-off-by: youkaichao <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link

@joschu-anthropic joschu-anthropic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Maybe for clarity you could slightly revise to something like
"vLLM needs to register custom ops, but this version of pytorch does not support it -- chances are you are using..."

Signed-off-by: youkaichao <[email protected]>
Copy link

@joschu-anthropic joschu-anthropic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@youkaichao youkaichao merged commit c954f21 into vllm-project:main Dec 20, 2024
13 of 15 checks passed
@youkaichao youkaichao deleted the supports_custom_op branch December 20, 2024 05:18
lucas-tucker pushed a commit to lucas-tucker/vllm-lucas-tucker that referenced this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants