Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix sliding window in cohere2 model #11358

Closed
wants to merge 3 commits into from

Conversation

CXIAAAAA
Copy link

@CXIAAAAA CXIAAAAA commented Dec 20, 2024

This one address the feature request: #11357

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@CXIAAAAA CXIAAAAA changed the title Add cohere2 model Fix cohere2 model Dec 20, 2024
@CXIAAAAA CXIAAAAA mentioned this pull request Dec 20, 2024
1 task
@DarkLight1337 DarkLight1337 changed the title Fix cohere2 model [Bugfix] Fix sliding window in cohere2 model Dec 20, 2024
@youkaichao
Copy link
Member

cache_config.sliding_window should be None for interleaving sliding window. fixing it in #11583 . thanks for reporting it!

@youkaichao youkaichao closed this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants