Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform] Do not use current_platform in global namespace #11362

Closed

Conversation

wangxiyuan
Copy link
Contributor

@wangxiyuan wangxiyuan commented Dec 20, 2024

Once platform pluggable supported, use current_platform in global namespace is dangerous. Because it's hard to guarantee that current_platform is initialized correctly when it's used in global namespace. It'll lead unexpected problem and is hard to debug.

This PR drop the current_platform usage in global namespace in most place.

There is a place which will be fixed in next PR for easier review.

  • HAS_TRITON

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@wangxiyuan wangxiyuan force-pushed the platform_namespace_fix branch 3 times, most recently from f69631d to e32fe71 Compare December 20, 2024 08:41
@wangxiyuan wangxiyuan mentioned this pull request Dec 20, 2024
1 task
@wangxiyuan wangxiyuan force-pushed the platform_namespace_fix branch from e32fe71 to acde0e0 Compare December 20, 2024 09:15
@wangxiyuan
Copy link
Contributor Author

No need now, see: #11602

@wangxiyuan wangxiyuan closed this Dec 30, 2024
@wangxiyuan wangxiyuan deleted the platform_namespace_fix branch December 30, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant