Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI/Build] fix pre-compiled wheel install for exact tag #11373

Merged
merged 1 commit into from
Dec 20, 2024
Merged

[CI/Build] fix pre-compiled wheel install for exact tag #11373

merged 1 commit into from
Dec 20, 2024
+1 −1

Conversation

dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented Dec 20, 2024 •
edited by github-actions bot
Loading

Fixes the precompiled wheel version for exact tags: a valid version must respect the following format [N!]N(.N)*[{a|b|rc}N][.postN][.devN]

fixes #11321

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Dec 20, 2024
@dtrifiro dtrifiro mentioned this pull request Dec 20, 2024
Closed
1 task
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 20, 2024 11:17
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 20, 2024
auto-merge was automatically disabled December 20, 2024 12:25

Head branch was pushed to by a user without write access

@dtrifiro dtrifiro force-pushed the fix-precompiled-wheel-installatation-exact-tags branch from 9307104 to e7ff6bc Compare December 20, 2024 12:25
@dtrifiro
Copy link
Contributor Author

@DarkLight1337 amended the commit to add DCO signoff

@DarkLight1337
Copy link
Member

Can you merge from main? I saw some other CI failures in the previous run.

@dtrifiro dtrifiro force-pushed the fix-precompiled-wheel-installatation-exact-tags branch from e7ff6bc to 6db371f Compare December 20, 2024 12:52
@DarkLight1337 DarkLight1337 merged commit 7c7aa37 into vllm-project:main Dec 20, 2024
75 checks passed
@dtrifiro dtrifiro deleted the fix-precompiled-wheel-installatation-exact-tags branch December 20, 2024 16:30
lucas-tucker pushed a commit to lucas-tucker/vllm-lucas-tucker that referenced this pull request Dec 21, 2024
@dtrifiro
[CI/Build] fix pre-compiled wheel install for exact tag (vllm-project…
8fc21ab 
…#11373)

Signed-off-by: Daniele Trifirò <[email protected]>
Signed-off-by: lucast2021 <[email protected]>
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@dtrifiro @BKitor
[CI/Build] fix pre-compiled wheel install for exact tag (vllm-project…
854ce28 
…#11373)

Signed-off-by: Daniele Trifirò <[email protected]>
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
@dtrifiro
[CI/Build] fix pre-compiled wheel install for exact tag (vllm-project…
e2228de 
…#11373)

Signed-off-by: Daniele Trifirò <[email protected]>
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
@dtrifiro
[CI/Build] fix pre-compiled wheel install for exact tag (vllm-project…
7d760ab 
…#11373)

Signed-off-by: Daniele Trifirò <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Error Encountered While Attempting Python-only Build (Without Compilation) for vLLM v0.6.5
2 participants
@dtrifiro @DarkLight1337