[Bugfix] Fix issues for Pixtral-Large-Instruct-2411
#11393
Merged
+15
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the mistral-format Pixtral implementation assumes all models under
PixtralForConditionalGeneration
have the same token id for[IMG_BREAK]
and[IMG_END]
tokens. This is in fact not true and thusPixtral-Large-Instruct-2411
is broken on 0.6.5.This PR adds a workaround to address this issue as well as fixing a bug where image features are inadvertently moved to
cuda
devices when they don't need to be.@patrickvonplaten As I mentioned offline, it would be great if these token IDs can be retrieved from the model config so that we won't need to hardcode them.