Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix issues for Pixtral-Large-Instruct-2411 #11393

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

ywang96
Copy link
Member

@ywang96 ywang96 commented Dec 21, 2024

Previously the mistral-format Pixtral implementation assumes all models under PixtralForConditionalGeneration have the same token id for [IMG_BREAK] and [IMG_END] tokens. This is in fact not true and thus Pixtral-Large-Instruct-2411 is broken on 0.6.5.

This PR adds a workaround to address this issue as well as fixing a bug where image features are inadvertently moved to cuda devices when they don't need to be.

@patrickvonplaten As I mentioned offline, it would be great if these token IDs can be retrieved from the model config so that we won't need to hardcode them.

fix
Signed-off-by: ywang96 <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 21, 2024 06:31
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 21, 2024
@DarkLight1337 DarkLight1337 merged commit c2d1b07 into vllm-project:main Dec 21, 2024
57 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants