Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Unify VLLM_ENABLE_V1_MULTIPROCESSING handling in RayExecutor #11472

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

ruisearch42
Copy link
Collaborator

@ruisearch42 ruisearch42 commented Dec 25, 2024

Follow up for #11107 (comment)
Since the EngineCoreClient and EngineCore may be in different processes, we initialize ray in the EngineCore process (specifically, in RayExecutor).

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@ruisearch42 ruisearch42 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 25, 2024
@comaniac comaniac merged commit 9832e55 into vllm-project:main Dec 25, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants