Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Use registry-based initialization for KV cache transfer connector. #11481

Merged
merged 1 commit into from
Dec 29, 2024
Merged

[Misc] Use registry-based initialization for KV cache transfer connector. #11481

merged 1 commit into from
Dec 29, 2024
+38 −18

Conversation

KuntaiDu
Copy link
Collaborator

@KuntaiDu KuntaiDu commented Dec 25, 2024 •
edited by github-actions bot
Loading

Use registry-based initialization for connector class. This allows people to add third-party connectors without writing a lot of if-else checks.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@KuntaiDu KuntaiDu requested a review from youkaichao December 25, 2024 04:54
KuntaiDu
KuntaiDu commented Dec 25, 2024
View reviewed changes
vllm/config.py
]):
raise ValueError(f"Unsupported kv_connector: {self.kv_connector}. "
f"Supported connectors are "
f"{supported_kv_connector}.")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this part of code --- this check will be done inside the kv connector factory class.

youkaichao
youkaichao approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thanks for adding it!

@youkaichao youkaichao enabled auto-merge (squash) December 29, 2024 14:39
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 29, 2024
@youkaichao
Copy link
Member

please also add some tests, examples, docs for it.

I think you can add them after we refactor the plugin tests in #11602

@youkaichao youkaichao merged commit faef77c into vllm-project:main Dec 29, 2024
71 checks passed
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@KuntaiDu @BKitor
[Misc] KV cache transfer connector registry (vllm-project#11481)
6b8ce76 
Signed-off-by: KuntaiDu <[email protected]>
xcnick pushed a commit to xcnick/vllm that referenced this pull request Dec 31, 2024
@KuntaiDu @xcnick
[Misc] KV cache transfer connector registry (vllm-project#11481)
41b22e3 
Signed-off-by: KuntaiDu <[email protected]>
Signed-off-by: xcnick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KuntaiDu @youkaichao