Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hardware][AMD]: Replace HIPCC version with more precise ROCm version #11515

Merged
merged 4 commits into from
Dec 28, 2024

Conversation

hj-wei
Copy link
Contributor

@hj-wei hj-wei commented Dec 26, 2024

Hi all, Ifound that the representation of the ROCm version is somewhat unclear. For instance, in the case of the current ROCm version 6.2.0, the version specified in setup.py is 624, which corresponds to the HIPCC version. To represent the ROCm version more accurately, I opted to utilize the version representation provided in the rocm-core package, which retrieves the ROCm version through the available version query interfaces.
see https://github.com/ROCm/rocm-core/blob/d11f5c20d500f729c393680a01fa902ebf92094b/rocm_version.cpp#L21

On the other hand, the HIPCC version can be directly obtained via torch.version.hip.

You can also directly use the ROCM_VERSION information provided by the torch package,https://github.com/pytorch/pytorch/blob/cf76c05b4dc629ac989d1fb8e789d4fac04a095a/torch/utils/cpp_extension.py#L244

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Dec 26, 2024
Copy link
Collaborator

@hongxiayang hongxiayang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please address the ruff/yapf failures.
Adding @tjtanaa to review too.

@tjtanaa
Copy link
Contributor

tjtanaa commented Dec 27, 2024

LGTM as well. RDNA also works.

Copy link
Collaborator

@hongxiayang hongxiayang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be merged as long as the CI passes.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping to review this!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 28, 2024 09:20
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 28, 2024
@DarkLight1337 DarkLight1337 merged commit 59d6bb4 into vllm-project:main Dec 28, 2024
88 checks passed
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
xcnick pushed a commit to xcnick/vllm that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed rocm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants