-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hardware][AMD]: Replace HIPCC version with more precise ROCm version #11515
Conversation
…ion retrieval Signed-off-by: hjwei <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: hjwei <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please address the ruff/yapf failures.
Adding @tjtanaa to review too.
Signed-off-by: hjwei <[email protected]>
LGTM as well. RDNA also works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be merged as long as the CI passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping to review this!
…vllm-project#11515) Signed-off-by: hjwei <[email protected]> Signed-off-by: xcnick <[email protected]>
Hi all, Ifound that the representation of the ROCm version is somewhat unclear. For instance, in the case of the current ROCm version 6.2.0, the version specified in setup.py is 624, which corresponds to the HIPCC version. To represent the ROCm version more accurately, I opted to utilize the version representation provided in the rocm-core package, which retrieves the ROCm version through the available version query interfaces.
see https://github.com/ROCm/rocm-core/blob/d11f5c20d500f729c393680a01fa902ebf92094b/rocm_version.cpp#L21
On the other hand, the HIPCC version can be directly obtained via torch.version.hip.
You can also directly use the ROCM_VERSION information provided by the torch package,https://github.com/pytorch/pytorch/blob/cf76c05b4dc629ac989d1fb8e789d4fac04a095a/torch/utils/cpp_extension.py#L244