Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V1] [5/N] API Server: unify Detokenizer and EngineCore input #11545

Merged
merged 16 commits into from
Dec 28, 2024
Merged

[V1] [5/N] API Server: unify Detokenizer and EngineCore input #11545

merged 16 commits into from
Dec 28, 2024
+66 −77

Conversation

robertgshaw2-neuralmagic
Copy link
Collaborator

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic commented Dec 27, 2024 •
edited by github-actions bot
Loading

SUMMARY:

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic changed the title [V1] [5/N] Remove DetokenizerRequest [V1] [5/N] API Server: unify Detokenizer and EngineCore input Dec 27, 2024
@mergify Mergify
Copy link

mergify bot commented Dec 27, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @robertgshaw2-neuralmagic.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 27, 2024
@mergify mergify bot removed the needs-rebase label Dec 27, 2024
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 28, 2024
mgoin
mgoin approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM!

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic merged commit 4fb8e32 into main Dec 28, 2024
53 checks passed
@robertgshaw2-neuralmagic robertgshaw2-neuralmagic deleted the remove-detokenizer-input branch December 28, 2024 20:51
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@robertgshaw2-neuralmagic @BKitor
[V1] [5/N] API Server: unify Detokenizer and EngineCore input (vl…
8fb61ef 
…lm-project#11545)

Signed-off-by: [email protected] <[email protected]>
xcnick pushed a commit to xcnick/vllm that referenced this pull request Dec 31, 2024
@robertgshaw2-neuralmagic @xcnick
[V1] [5/N] API Server: unify Detokenizer and EngineCore input (vl…
6e19644 
…lm-project#11545)

Signed-off-by: [email protected] <[email protected]>
Signed-off-by: xcnick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-neuralmagic alexm-neuralmagic Awaiting requested review from alexm-neuralmagic alexm-neuralmagic is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertgshaw2-neuralmagic @mgoin