Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hip sources to be directly included when compiling for rocm. #12087

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

tvirolai-amd
Copy link
Contributor

@tvirolai-amd tvirolai-amd commented Jan 15, 2025

vLLM csrc contents are always hipified unless they are .cpp or .cc files. This causes issues when one wants to compile hip files:

If the file is named .cu then hipification either chokes on hip exclusive things or it skips it because there is nothing to hipify, meaning the .hip equivalent is not created and build fails. In addition it is confusing to call the files .cu if they are not actually valid cuda source but hip sources.

If the file is named .hip the compilation breaks due to cyclic dependency as foo.hip depends on foo.hip.

This simple change let's .hip files be excluded from hipifaction process while allowing them to automatically be recognized as hip by clang.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jan 15, 2025
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 15, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks

@mgoin mgoin merged commit cd9d06f into vllm-project:main Jan 15, 2025
46 checks passed
ice-tong pushed a commit to ice-tong/vllm that referenced this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants