-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VLM] Merged multi-modal processor for Pixtral #12211
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: remi <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: remi <[email protected]>
41c423a
to
4af1716
Compare
Signed-off-by: remi <[email protected]>
Signed-off-by: remi <[email protected]>
Signed-off-by: remi <[email protected]>
Signed-off-by: remi <[email protected]>
Signed-off-by: remi <[email protected]>
#12767 should make it easier to pass the image token ID |
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: remi <[email protected]>
Any update on this? |
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: remi <[email protected]>
Signed-off-by: remi <[email protected]>
Signed-off-by: remi <[email protected]>
Signed-off-by: remi <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Thanks for updating! I'm going to push some code improvements / fixes to get this merged sooner. |
Signed-off-by: DarkLight1337 <[email protected]>
I've updated the processor to more closely follow the design of the other models. However there is still a mismatch in the placeholder tokens, would be great if anyone could help debug this in the meantime! |
return tokenizer.decode(token_ids, skip_special_tokens=skip_special_tokens) | ||
if skip_special_tokens is not None: | ||
return tokenizer.decode(token_ids, | ||
skip_special_tokens=skip_special_tokens) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change lets us avoid passing skip_special_tokens=False
to MistralTokenizer
which isn't allowed.
Signed-off-by: DarkLight1337 <[email protected]>
This PR aims at implementing the merged multi-modal processor for Pixtral as an effort to contribute to the V1 re-arch for multi-modal models.