Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VLM] Merged multi-modal processor for Pixtral #12211

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

Flechman
Copy link

This PR aims at implementing the merged multi-modal processor for Pixtral as an effort to contribute to the V1 re-arch for multi-modal models.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Flechman Flechman force-pushed the pixtral-mm-processor branch from 41c423a to 4af1716 Compare January 26, 2025 12:19
@DarkLight1337
Copy link
Member

#12767 should make it easier to pass the image token ID

Copy link

mergify bot commented Feb 13, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @Flechman.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 13, 2025
Signed-off-by: remi <[email protected]>
@mergify mergify bot removed the needs-rebase label Feb 14, 2025
@DarkLight1337
Copy link
Member

Any update on this?

@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Mar 8, 2025
Copy link

mergify bot commented Mar 8, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @Flechman.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 8, 2025
Signed-off-by: remi <[email protected]>
@mergify mergify bot removed the needs-rebase label Mar 9, 2025
@Flechman Flechman marked this pull request as ready for review March 9, 2025 22:51
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Copy link
Member

Thanks for updating! I'm going to push some code improvements / fixes to get this merged sooner.

Signed-off-by: DarkLight1337 <[email protected]>
@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 10, 2025
@DarkLight1337
Copy link
Member

I've updated the processor to more closely follow the design of the other models. However there is still a mismatch in the placeholder tokens, would be great if anyone could help debug this in the meantime!

return tokenizer.decode(token_ids, skip_special_tokens=skip_special_tokens)
if skip_special_tokens is not None:
return tokenizer.decode(token_ids,
skip_special_tokens=skip_special_tokens)
Copy link
Member

@DarkLight1337 DarkLight1337 Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change lets us avoid passing skip_special_tokens=False to MistralTokenizer which isn't allowed.

Signed-off-by: DarkLight1337 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation multi-modality Related to multi-modality (#4194)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants