[MISC][V1] Handle exception of current_platform.get_device_name() in arg_utils #14379
+13
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
current_platform.get_device_name()
inarg_utils.py
is too early and is not compatible with Ray, because Ray Serve may import vLLM at the main actor to use some of its data structures. Since this actor doesn't have GPU and is not the actor that actually runs the engine, we will get an exception about no GPU devices. This PR makes this early device query optional to workaround this issue. It should not affect any existing use cases and should not impact user experience, given that the only difference without querying device inEngineArgs._override_v1_engine_args
isdefault_max_num_batched_tokens
.cc @WoosukKwon