Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC][V1] Handle exception of current_platform.get_device_name() in arg_utils #14379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

comaniac
Copy link
Collaborator

@comaniac comaniac commented Mar 6, 2025

The use of current_platform.get_device_name() in arg_utils.py is too early and is not compatible with Ray, because Ray Serve may import vLLM at the main actor to use some of its data structures. Since this actor doesn't have GPU and is not the actor that actually runs the engine, we will get an exception about no GPU devices. This PR makes this early device query optional to workaround this issue. It should not affect any existing use cases and should not impact user experience, given that the only difference without querying device in EngineArgs._override_v1_engine_args is default_max_num_batched_tokens.

cc @WoosukKwon

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 6, 2025
@comaniac comaniac changed the title [MISC] Handle exception of current_platform.get_device_name() in arg_utils [MISC][V1] Handle exception of current_platform.get_device_name() in arg_utils Mar 6, 2025
@njhill njhill requested a review from youkaichao March 7, 2025 15:14
@njhill
Copy link
Member

njhill commented Mar 7, 2025

cc @youkaichao

@comaniac comaniac force-pushed the device-no-query branch 2 times, most recently from 99ff96e to 52ba2e3 Compare March 7, 2025 17:06
Signed-off-by: Cody Yu <[email protected]>
@comaniac comaniac enabled auto-merge (squash) March 10, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants