Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a patch for the bug reported in issue #17396. The LoRA weights embedding layers can have a different amount of padding than the weights of the base model, depending on what hardware the model and LoRA adapters are running on. The existing code in the
bgmv_expand()
kernel compensates for this difference when the LoRA weights have more padding, but it does not compensate for the difference when the LoRA weights have less padding. When LoRA adapters are used on CPU or MPS hardware with default parameters, the LoRA weights have less padding and the server crashes with a PyTorch tensor size mismatch error.This patch updates the logic in
bgmv_expand()
so that it works regardless of which set of embeddings, LoRA or base, contain more padding dimensions.FIX #17396
(anything written below this line will be removed by GitHub Actions)