-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[Model] Add support for normalized Transformer (nGPT) from NVIDIA #18798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Shantanu Acharya <[email protected]>
Signed-off-by: Shantanu Acharya <[email protected]>
Signed-off-by: Shantanu Acharya <[email protected]>
Signed-off-by: Shantanu Acharya <[email protected]>
Signed-off-by: Shantanu Acharya <[email protected]>
Signed-off-by: Shantanu Acharya <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
cc @hmellor could transformers fallback support this model if only the rope scaling is implemented in vLLM? |
Looking at the transformers PR it looks like it would probably be compatible with the transformers backend. If there are no public checkpoints I cannot test though. The rope scaling is also implemented in the transformers code, so there should be no need for anything specific to this model to exist in vLLM. The model could still be "officially" supported if it were added to the registry as: "NGPTForCausalLM": ("transformers", "TransformersForCausalLM"), (there may be other changes necessary as we've not done this before) |
@DarkLight1337 @hmellor are there any drawbacks to have the code for the model directly in native vLLM? If it is merged via the transformers backend will it still give the same inference speedup benefits that we see with vLLM? |
Mainly:
Yeah, the transformers backend uses vLLM's attention module so still gets all the benefits of doing so (paged attention, tp/pp, FA/FI, etc). Depending on how performant your Transformers modelling code is you may see some performance difference though. You can try it with |
This pull request has merge conflicts that must be resolved before it can be |
Adds a new architecture called normalized Transformer (nGPT) (Paper).
FIX #18797
We are planning to release a model based on a new architecture called normalized transformer (nGPT) and would like to have vllm support for it.