-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[Deprecation] Remove prompt_token_ids
arg fallback in LLM.generate
and LLM.embed
#18800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Deprecation] Remove prompt_token_ids
arg fallback in LLM.generate
and LLM.embed
#18800
Conversation
Signed-off-by: DarkLight1337 <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
prompt_token_ids
arg fallbackprompt_token_ids
arg fallback in LLM
prompt_token_ids
arg fallback in LLM
prompt_token_ids
arg fallback in LLM.generate
and LLM.embed
Signed-off-by: DarkLight1337 <[email protected]>
Looks like Edit: Opened EleutherAI/lm-evaluation-harness#3024 |
Signed-off-by: DarkLight1337 <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: DarkLight1337 <[email protected]>
First introduced all the way back in #4328, with deprecation flag turned on in #11129. This should be safe to remove.