Skip to content

[Deprecation] Remove prompt_token_ids arg fallback in LLM.generate and LLM.embed #18800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DarkLight1337
Copy link
Member

First introduced all the way back in #4328, with deprecation flag turned on in #11129. This should be safe to remove.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label May 28, 2025
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 changed the title [Deprecation] Remove prompt_token_ids arg fallback [Deprecation] Remove prompt_token_ids arg fallback in LLM May 28, 2025
@DarkLight1337 DarkLight1337 changed the title [Deprecation] Remove prompt_token_ids arg fallback in LLM [Deprecation] Remove prompt_token_ids arg fallback in LLM.generate and LLM.embed May 28, 2025
Signed-off-by: DarkLight1337 <[email protected]>
@mergify mergify bot added the documentation Improvements or additions to documentation label May 28, 2025
@DarkLight1337
Copy link
Member Author

DarkLight1337 commented May 28, 2025

Looks like lm_eval still uses the deprecated parameter prompt_token_ids. Let me open an issue on their end.

Edit: Opened EleutherAI/lm-evaluation-harness#3024

Signed-off-by: DarkLight1337 <[email protected]>
@mergify mergify bot added the v1 label May 28, 2025
Copy link

mergify bot commented May 29, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @DarkLight1337.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 29, 2025
@DarkLight1337 DarkLight1337 marked this pull request as draft May 29, 2025 16:41
@mergify mergify bot removed the needs-rebase label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation frontend ready ONLY add when PR is ready to merge/full CI is needed structured-output v1
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant