-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[Model] NemotronH support #18863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Model] NemotronH support #18863
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Luis Vega <[email protected]>
Could this model be run with If yes (or if it would be easy to fix), I'd propose supporting this model via the transformers backend instead of duplicating the modelling code in vLLM. |
Hi @hmellor , This vLLM implementation is way faster than could you elaborate more on what do you mean by "duplicating the modelling code in vLLM."? |
I'm not suggesting that you don't use vLLM. I'm referring to the Transformers backend for vLLM https://docs.vllm.ai/en/latest/models/supported_models.html#transformers
This PR adds 800 lines of modelling code that already exists in Transformers. |
This pull request has merge conflicts that must be resolved before it can be |
Thanks for the pointers @hmellor, I went through them. However, I don't think this will work well given that this is a hybrid model, based on mamba and attention layers, that requires more than just replacing an attention backend to work well in vLLM. Also, the I re-used as much vLLM code as I could including mamba-mixer2 layer and other components used in other hybrid models such as Bamba. Let me know what you think. |
Ah I see, I have not tried with mamba style hybrid models (sliding window hybrid models do work though). In that case this model is likely not a good candidate for the transformers backend in its current state. Thanks for taking the time to look into the transformers backend though 🤗 |
Great @hmellor , I will start working on getting pre-commit to work and rebasing. I will keep you posted. |
This PR adds support to NemotronH family models: