-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] Initialize Fuyu-8B support #3924
Conversation
Test code (with CPU backend): from vllm import LLM
from vllm import SamplingParams
llm = LLM("/data/LLM-model/persimmon-8b-chat", enforce_eager=True, max_model_len=4096)
prompts = [
"human: Who was the first emperor of Rome?\nadept:",
"human: Where is Guangzhou City?\nadept:",
]
sampling_params = SamplingParams(temperature=0.8, top_p=0.95, max_tokens=128, stop="adept:")
outputs = llm.generate(prompts, sampling_params)
# Print the outputs.
for output in outputs:
prompt = output.prompt
generated_text = output.outputs[0].text
print(f"Prompt: {prompt!r}, Generated text: {generated_text!r}") Outputs:
|
Does the image input also work? |
OK, I haven't finished the code for |
Image input also works now: Example Codeimport torch
from vllm import LLM, SamplingParams
from vllm.sequence import MultiModalData
# images = torch.load("images/stop_sign_pixel_values.pt")
images = torch.load("images/cherry_blossom_pixel_values.pt")
# for image_prompt initialization
_, _, H, W = images.shape
nrow = H // 30 + 1 if H % 30 else H // 30
ncol = W // 30 + 1 if W % 30 else W // 30
image_prompt = ("|SPEAKER|" * ncol + "|NEWLINE|") * nrow
prompt = image_prompt + "Generate a coco-style caption.\n"
llm = LLM(
"/data/LLM-model/fuyu-8b",
enforce_eager=True,
image_input_type="pixel_values",
image_token_id=71011,
# below makes no sense to fuyu, just make model_executor happy
image_input_shape="1,576,1024",
image_feature_size=2700,
)
sampling_params = SamplingParams(temperature=0.8, top_p=0.95, max_tokens=16)
outputs = llm.generate(
prompt,
sampling_params,
multi_modal_data=MultiModalData(MultiModalData.Type.IMAGE, images),
)
# Print the outputs.
for output in outputs:
generated_text = output.outputs[0].text
print(f"Generated text: {generated_text!r}") Outputs
|
@simon-mo Can you take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM one comment about some additional model specific assertions.
Seems that the failed workflow is related to the network issue... |
Are you going to implement multi-scale input in another PR? Or is the change in image size just to get the strict equality tests to pass? |
The change in image size is just to prevent OOM in test. Using |
Hmm, I'm concerned that limiting the image size would undermine the completeness of the test. It looks like the OOM also happens on the other models so it might just be that this particular test machine doesn't have a big enough GPU. |
In my test, |
A potential issue of limiting the image size is that we can't test whether the model can still handle the out of box HD image. |
Can you adjust the vLLM -> HF output conversion? The texts are a bit inconsistent (check the warnings emitted in the CI) |
@ywang96 can you take a look at this as well and offer your opinions regarding OOM in the test? |
@Isotr0py Sorry for the late review! Overall LGTM but let me update this PR with main and test it out locally with a better GPU and see if the tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the updated PR with the following size factors locally and the outputs look good to me,
"size_factors",
[
# No image
[],
# Single-scale
[1.0],
# Single-scale, batched
[1.0, 1.0, 1.0],
# Multi-scale
[0.25, 0.5, 1.0],
],
)
so I'm giving PR a green light as well. Thank you @Isotr0py for all the work on this PR!
Co-authored-by: Roger Wang <[email protected]>
Co-authored-by: Roger Wang <[email protected]>
Co-authored-by: Roger Wang <[email protected]> Signed-off-by: Alvant <[email protected]>
FILL IN THE PR DESCRIPTION HERE
Fix #2262
This PR adds support for persimmon-8b and fuyu-8B models.
Updated TODO:
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!