Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another function tool implement compared to #3237. This PR is simple and flexible. And this idea was inspired by https://github.com/huggingface/transformers/blob/main/src/transformers/models/cohere/tokenization_cohere_fast.py
That leveraged
transformers
rich chat template support.Discussions
tools
parameters follow openai' design strictly, which have a fixed json format? although this server is named openai_server.tool_calls
in openai response sometimes is unnecessary. For example, if prompt: 'Send email to Roy', after model returns tool call, my task finished. And i don't needtool_calls
for summary anymore.documents
parameter, whether we will use this information for future features? like RAG Speculative decoding and something else that accelerates RAG inference.TODO
Further ideas
For RAG applications, it's also useful to have a indicator(prefix_stop) to adapt prefix caching.
vllm-client
. This might be not related to this PR.