-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hardware][Intel CPU][DOC] Update docs for CPU backend #6212
[Hardware][Intel CPU][DOC] Update docs for CPU backend #6212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to offer some proofreading for grammar and readability :)
7e96e83
to
acb0913
Compare
Hi @WoosukKwon I have made updates to the CPU documentation to reflect the recent changes. Could you please review these diff? thanks, -yuan |
Could you please kindly help to take a look on this? This diff is pure for CPU backend doc update. thanks, -yuan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the cpu-installation
part of this doc update. Thanks for updating documentation about new feature on CPU backend!
Let's see if others can have a look on nginx server part. (I'm not familiar with the nginx server deployment)
@simon-mo do you know anyone who can review this? |
Thank you! @Isotr0py @DarkLight1337
The intention here is to make one example for multiple instances base deployment: e.g., a load-balancer in the front + several vLLM serving endpoints. It is indeed not bounded to CPU backend. Not sure where is the best place to put this part. I'm OK to move this to somewhere else. thanks, -yuan |
Seems that the |
25f9703
to
fc1f394
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm please can you edit the documentation with gpu example? That's the primary reader's use case |
Hi Simon, make sense, I will modify to use GPU docker as the example. thanks, -yuan |
Head branch was pushed to by a user without write access
This patch adds the typical deployment considerations for vLLM with CPU backend. Signed-off-by: Yuan Zhou <[email protected]>
Co-authored-by: Rafael Vasquez <[email protected]>
Co-authored-by: Rafael Vasquez <[email protected]>
Co-authored-by: Rafael Vasquez <[email protected]>
Fixing a couple of typos
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
cdf8055
to
85d0ea0
Compare
…6212) Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Rafael Vasquez <[email protected]> Co-authored-by: Gubrud, Aaron D <[email protected]> Co-authored-by: adgubrud <[email protected]> Signed-off-by: charlifu <[email protected]>
…6212) Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Rafael Vasquez <[email protected]> Co-authored-by: Gubrud, Aaron D <[email protected]> Co-authored-by: adgubrud <[email protected]> Signed-off-by: Alvant <[email protected]>
…6212) Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Rafael Vasquez <[email protected]> Co-authored-by: Gubrud, Aaron D <[email protected]> Co-authored-by: adgubrud <[email protected]> Signed-off-by: Erkin Sagiroglu <[email protected]>
…6212) Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Rafael Vasquez <[email protected]> Co-authored-by: Gubrud, Aaron D <[email protected]> Co-authored-by: adgubrud <[email protected]> Signed-off-by: Amit Garg <[email protected]>
…6212) Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Rafael Vasquez <[email protected]> Co-authored-by: Gubrud, Aaron D <[email protected]> Co-authored-by: adgubrud <[email protected]> Signed-off-by: qishuai <[email protected]>
…6212) Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Rafael Vasquez <[email protected]> Co-authored-by: Gubrud, Aaron D <[email protected]> Co-authored-by: adgubrud <[email protected]> Signed-off-by: NickLucche <[email protected]>
…6212) Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Rafael Vasquez <[email protected]> Co-authored-by: Gubrud, Aaron D <[email protected]> Co-authored-by: adgubrud <[email protected]> Signed-off-by: NickLucche <[email protected]>
…6212) Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Rafael Vasquez <[email protected]> Co-authored-by: Gubrud, Aaron D <[email protected]> Co-authored-by: adgubrud <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
…6212) Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Rafael Vasquez <[email protected]> Co-authored-by: Gubrud, Aaron D <[email protected]> Co-authored-by: adgubrud <[email protected]>
…6212) Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Rafael Vasquez <[email protected]> Co-authored-by: Gubrud, Aaron D <[email protected]> Co-authored-by: adgubrud <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
…6212) Signed-off-by: Yuan Zhou <[email protected]> Co-authored-by: Rafael Vasquez <[email protected]> Co-authored-by: Gubrud, Aaron D <[email protected]> Co-authored-by: adgubrud <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
This patch adds the typical deployment considerations for vLLM with CPU backend, since it's different with the GPU backend.
related #3654
https://vllm--6212.org.readthedocs.build/en/6212/
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!