-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kernel] Turn off CUTLASS scaled_mm for Ada Lovelace #6384
[Kernel] Turn off CUTLASS scaled_mm for Ada Lovelace #6384
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Full CI run is still required to merge this PR so please make sure that you run full CI before merging or if you need more test signals. To run full CI, you can do one of these:
🚀 |
This should fix #6240 In a future PR we'll tune the CUTLASS SM89 FP8 kernels. We will need to do this anyway for the int8 case as well. |
/ready |
tweaked scores b/c the test failed after changing from cutlass --> scaled_mm (note: I will re-run these with 1000 samples instead of 250 so they are more stable)
@tlrmchlsmth FYI - the lm-eval regression tests failed because the score for fp8 llama changed a bit for fp8 with this change. I just tweaked the values in the config. Note: we are only running 250 samples for this model. I will re-run with 1000 samples so its a bit more stable in a separate PR |
@robertgshaw2-neuralmagic thanks. Looks like we're failing on the GPTQ marlin tests as well. Are those flakey? |
yes due to nondeteminism. will rerun |
Signed-off-by: Alvant <[email protected]>
We haven't tuned the cutlass kernels for SM89 and performance is very bad.
The following benchmarks were run on an L40 with
Using the CUTLASS kernels:
Using torch.scaled_mm:
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!