Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel] Turn off CUTLASS scaled_mm for Ada Lovelace #6384

Merged

Conversation

tlrmchlsmth
Copy link
Collaborator

We haven't tuned the cutlass kernels for SM89 and performance is very bad.

The following benchmarks were run on an L40 with

    python benchmarks/benchmark_serving.py \
    --backend openai \
    --model neuralmagic/Meta-Llama-3-8B-Instruct-FP8 \
    --dataset-path ShareGPT_V3_unfiltered_cleaned_split.json \
    --request-rate 1 \
    --num-prompts 200 \
    --port 8000

Using the CUTLASS kernels:

============ Serving Benchmark Result ============
Successful requests:                     200
Benchmark duration (s):                  211.44
Total input tokens:                      42659
Total generated tokens:                  41049
Request throughput (req/s):              0.95
Input token throughput (tok/s):          201.76
Output token throughput (tok/s):         194.14
---------------Time to First Token----------------
Mean TTFT (ms):                          71.19
Median TTFT (ms):                        63.17
P99 TTFT (ms):                           159.21
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          35.87
Median TPOT (ms):                        35.42
P99 TPOT (ms):                           46.35
---------------Inter-token Latency----------------
Mean ITL (ms):                           35.67
Median ITL (ms):                         33.55
P99 ITL (ms):                            102.87
==================================================

Using torch.scaled_mm:

============ Serving Benchmark Result ============
Successful requests:                     200
Benchmark duration (s):                  202.07
Total input tokens:                      42659
Total generated tokens:                  40851
Request throughput (req/s):              0.99
Input token throughput (tok/s):          211.11
Output token throughput (tok/s):         202.16
---------------Time to First Token----------------
Mean TTFT (ms):                          30.50
Median TTFT (ms):                        29.03
P99 TTFT (ms):                           60.73
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          16.58
Median TPOT (ms):                        16.46
P99 TPOT (ms):                           19.92
---------------Inter-token Latency----------------
Mean ITL (ms):                           16.52
Median ITL (ms):                         16.09
P99 ITL (ms):                            33.85
==================================================

PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Model] for adding a new model or improving an existing model. Model name should appear in the title.
  • [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
  • [Kernel] for changes affecting CUDA kernels or other compute kernels.
  • [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
  • [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • We adhere to Google Python style guide and Google C++ style guide.
  • Pass all linter checks. Please use format.sh to format your code.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
  • Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

  • After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
  • After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
  • After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
  • Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only trigger fastcheck CI to run, which consists only a small and essential subset of tests to quickly catch small errors.

Full CI run is still required to merge this PR so please make sure that you run full CI before merging or if you need more test signals.

To run full CI, you can do one of these:

  • Add ready label to the PR
  • Comment /ready on the PR
  • Enable auto-merge.

🚀

@tlrmchlsmth
Copy link
Collaborator Author

This should fix #6240

In a future PR we'll tune the CUTLASS SM89 FP8 kernels. We will need to do this anyway for the int8 case as well.

@tlrmchlsmth
Copy link
Collaborator Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 12, 2024
@comaniac comaniac enabled auto-merge (squash) July 12, 2024 19:38
tweaked scores b/c the test failed after changing from cutlass --> scaled_mm 

(note: I will re-run these with 1000 samples instead of 250 so they are more stable)
@robertgshaw2-neuralmagic
Copy link
Collaborator

robertgshaw2-neuralmagic commented Jul 13, 2024

@tlrmchlsmth FYI - the lm-eval regression tests failed because the score for fp8 llama changed a bit for fp8 with this change. I just tweaked the values in the config.

Note: we are only running 250 samples for this model. I will re-run with 1000 samples so its a bit more stable in a separate PR

@tlrmchlsmth
Copy link
Collaborator Author

@robertgshaw2-neuralmagic thanks. Looks like we're failing on the GPTQ marlin tests as well. Are those flakey?

@robertgshaw2-neuralmagic
Copy link
Collaborator

@robertgshaw2-neuralmagic thanks. Looks like we're failing on the GPTQ marlin tests as well. Are those flakey?

yes due to nondeteminism. will rerun

@comaniac comaniac merged commit 9dad5cc into vllm-project:main Jul 14, 2024
72 checks passed
dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request Jul 17, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Performance : slow inference for FP8 on L20 with 0.5.1(v0.5.0.post1 was fine)
5 participants