Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Convert image to RGB by default #6430

Merged
merged 5 commits into from
Jul 15, 2024
Merged

[Bugfix] Convert image to RGB by default #6430

merged 5 commits into from
Jul 15, 2024

Conversation

DarkLight1337
Copy link
Member

FIX #6427

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only trigger fastcheck CI to run, which consists only a small and essential subset of tests to quickly catch errors with the flexibility to run extra individual tests on top (you can do this by unblocking test steps in the Buildkite run).

Full CI run is still required to merge this PR so once the PR is ready to go, please make sure to run it. If you need all test signals in between PR commits, you can trigger full CI as well.

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 mentioned this pull request Jul 15, 2024
Closed
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 15, 2024
@DarkLight1337 DarkLight1337 requested a review from ywang96 July 15, 2024 03:03
ywang96
ywang96 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

vllm/multimodal/utils.py Outdated Show resolved Hide resolved
ywang96
ywang96 requested changes Jul 15, 2024
View reviewed changes
Copy link
Member

@ywang96 ywang96 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to update accordingly async fetch_image accordingly to what you did with fetch_image

@ywang96 ywang96 enabled auto-merge (squash) July 15, 2024 03:37
@ywang96 ywang96 merged commit de19916 into vllm-project:main Jul 15, 2024
74 checks passed
@DarkLight1337 DarkLight1337 deleted the image-rgb branch July 15, 2024 05:40
dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request Jul 17, 2024
@DarkLight1337 @dtrifiro
[Bugfix] Convert image to RGB by default (vllm-project#6430)
af62b48
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
@DarkLight1337
[Bugfix] Convert image to RGB by default (vllm-project#6430)
76b6e78
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@DarkLight1337 @Alvant
[Bugfix] Convert image to RGB by default (vllm-project#6430)
b382747 
Signed-off-by: Alvant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywang96 ywang96 ywang96 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Paligemma support for PNG files
2 participants
@DarkLight1337 @ywang96