[Bugfix] Fix for multinode crash on 4 PP #6495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Full CI run is still required to merge this PR so once the PR is ready to go, please make sure to run it. If you need all test signals in between PR commits, you can trigger full CI as well. To run full CI, you can do one of these:
🚀 |
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
andoorve
changed the title
andoorve
changed the title
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
Jul 17, 2024
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
fialhocoelho
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
Jul 19, 2024
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
gnpinkert
pushed a commit
to gnpinkert/vllm
that referenced
this pull request
Jul 26, 2024
Signed-off-by: Muralidhar Andoorveedu <[email protected]>
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
Signed-off-by: Muralidhar Andoorveedu <[email protected]> Signed-off-by: Alvant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to merge #6235 to allow for correct TP/PP rank assignment within a node. However, this caused our driver worker assignment to be out of sync now. This was partially fixed by #6399. However, the order of the TP drivers might be out of order causing the wrong worker to return the final answer.
For example we get for TP drivers:
We need to sort TP drivers to get
cc: @youkaichao