-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix][CI/Build][Hardware][AMD] Fix AMD tests, add HF cache, update CK FA, add partially supported model notes #6543
[Bugfix][CI/Build][Hardware][AMD] Fix AMD tests, add HF cache, update CK FA, add partially supported model notes #6543
Conversation
/ready |
How is peft related to boto3 and awscli? Could you explain more? |
e503f7c
to
2ce715f
Compare
e75ec14
to
196b461
Compare
It's linked via |
85ac29c
to
cf793c0
Compare
675dfdd
to
266af2d
Compare
Rebased, fixed one more test regression, and is all green except LM Eval Small Models which seems to be broken in main. Ready to ship! |
… CK FA, add partially supported model notes (vllm-project#6543)
… CK FA, add partially supported model notes (vllm-project#6543)
… CK FA, add partially supported model notes (vllm-project#6543)
… CK FA, add partially supported model notes (vllm-project#6543) Signed-off-by: Alvant <[email protected]>
… CK FA, add partially supported model notes (vllm-project#6543)
This PR attempts to fix existing failures on AMD tests.
vllm_flash_attn
invllm/spec_decode/draft_model_runner.py
. This is not installed on ROCm, so the correct ROCm FA component is used instead.flashinfer
in a way that is not supported on ROCm. This installation is made optional: this shouldn't affect the esoteric case whereflashinfer
isn't correctly installed during CUDA tests, because 1. this will give an obvious error message at the beginning of the test and 2.flashinfer
ModuleNotFoundError
is also pretty obvious.peft
(due to [CORE] Adding support for insertion of soft-tuned prompts #4645) which is not currently installed in the AMD container. This in turns wants updatedbotocore
and henceboto3
andawscli
. These requirements are included inrequirements-test.txt
but are a small subset of it, so we do not install it for now. Once more AMD tests are enabled, we will begin usingrequirements-test.txt
in earnest.PaliGemma
full-precision tests (added in [Model] Add PaliGemma #5189) and multimodal broadcast withPhi-3-Vision
. This is due to issues during Triton compilation which is solved by updating Triton.Phi-3-Vision
andPaliGemma
are still problematic under certain settings because too much shared memory is reserved by the Triton kernel on some devices. As a temporary workaround, CK FA is updated and used instead for the relevant tests and the associated warnings for partial model support in ROCm are added.PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!