-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] [SpecDecode] AsyncMetricsCollector: update time since last collection #6578
Conversation
Signed-off-by: Thomas Parnell <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
Signed-off-by: Thomas Parnell <[email protected]>
I added a test to catch this, it fails on Pretty confident that this is in fact a bug now. It effectively defeats the whole purpose of trying to copy the tensors periodically 😄 Fixing this can potentially improve performance. /ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thanks for adding a test as well :)
Can we get a force merge for the intel test? @simon-mo ty |
🫡 |
…ollection (vllm-project#6578) Signed-off-by: Alvant <[email protected]>
Fix #6577
IDK if I misunderstood something here, but looks like we basically sync the metrics every time (unless one is in-flight) and don't respect the
collect_interval_s
after the very first collection.cc @cadedaniel @njhill