[Misc] Fix input_scale typing in w8a8_utils.py #6579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
robertgshaw2-neuralmagic
approved these changes
Jul 19, 2024
mgoin
force-pushed
the
w8a8-input-scale-none
branch
from
d048985 to
63bc660
Compare
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
gnpinkert
pushed a commit
to gnpinkert/vllm
that referenced
this pull request
Jul 26, 2024
cduk
pushed a commit
to cduk/vllm-pascal
that referenced
this pull request
Aug 6, 2024
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
Signed-off-by: Alvant <[email protected]>
KuntaiDu
pushed a commit
to KuntaiDu/vllm
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small issue where it wasn't clear that input_scale could be None, which triggers dynamic scaling.