Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] Build wheel in release model when sccache is not enabled #6710

Closed
wants to merge 1 commit into from

Conversation

zifeitong
Copy link
Contributor

@zifeitong zifeitong commented Jul 23, 2024

Currently it's only enabled if [ "$USE_SCCACHE" = "1" ].

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@zifeitong zifeitong marked this pull request as ready for review July 24, 2024 00:23
@zifeitong
Copy link
Contributor Author

zifeitong commented Jul 24, 2024

Build log with sccache: https://buildkite.com/vllm/fastcheck/builds/903#0190e1fe-c9db-4912-ab22-1d01655e1dbe/128-3946

Also tested locally without sccache.

@zifeitong
Copy link
Contributor Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 24, 2024
@zifeitong zifeitong closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant